FOSS/nethogs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #215 from ncfavier/capability-check

Browse Source 
Disable capability check, handle failure better
This commit is contained in:
Arnout Engelen
2021-12-02 14:14:32 +01:00
committed by GitHub
parent 3e0bba6966 afb5759cc3
commit 54f88038f6
1 changed files with 7 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/main.cpp
View File

@@ -206,27 +206,11 @@ int main(int argc, char **argv) {
init_ui(); init_ui();
} }
if (geteuid() != 0) { #ifndef __linux__
#ifdef __linux__ if (geteuid() != 0)
char exe_path[PATH_MAX];
ssize_t len;
unsigned int caps[5] = {0, 0, 0, 0, 0};
if ((len = readlink("/proc/self/exe", exe_path, PATH_MAX)) == -1)
forceExit(false, "Failed to locate nethogs binary.");
exe_path[len] = '\0';
getxattr(exe_path, "security.capability", (char *)caps, sizeof(caps));
if ((((caps[1] >> CAP_NET_ADMIN) & 1) != 1) ||
(((caps[1] >> CAP_NET_RAW) & 1) != 1))
forceExit(false, "To run nethogs without being root you need to enable "
"capabilities on the program (cap_net_admin, "
"cap_net_raw), see the documentation for details.");
#else
forceExit(false, "You need to be root to run NetHogs!"); forceExit(false, "You need to be root to run NetHogs!");
#endif #endif
} // on Linux, we can run as non-root given the cap_net_admin and cap_net_raw capabilities
// use the Self-Pipe trick to interrupt the select() in the main loop // use the Self-Pipe trick to interrupt the select() in the main loop
self_pipe = create_self_pipe(); self_pipe = create_self_pipe();
@@ -292,6 +276,10 @@ int main(int argc, char **argv) {
} }
if (nb_devices == nb_failed_devices) { if (nb_devices == nb_failed_devices) {
if (geteuid() != 0)
fprintf(stderr, "To run nethogs without being root, you need to enable "
"capabilities on the program (cap_net_admin, cap_new_raw). "
"See the documentation for details.\n");
forceExit(false, "Error opening pcap handlers for all devices.\n"); forceExit(false, "Error opening pcap handlers for all devices.\n");
} }