FOSS/nethogs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix nethogsmonitor_loop_devices_py to accept more than one device

Browse Source 
Without the ref only the last element of __devicenames is stored in
_devicenames: The temporary is deleted at the end of the for body,
therefore the pointer to the c_str is no longer valid and might be
reused by the implementation. By using a reference in the for head
the c_str does not return a ref to the temporary but to the original
array wich's lifetime is till the end of the function.
This commit is contained in:
Andreas Gocht-Zech
2023-12-22 18:42:02 +01:00
parent eed54a0543
commit 8958ef0b3e
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
python/bindings.cpp
View File

@@ -52,7 +52,10 @@ int nethogsmonitor_loop_devices_py(
{ {
// this is ok because we only use the vector here // this is ok because we only use the vector here
std::vector<char*> _devicenames; std::vector<char*> _devicenames;
for (auto _dn : __devicenames) _devicenames.push_back(const_cast<char*>(_dn.c_str())); for (auto& _dn : __devicenames)
{
_devicenames.push_back(const_cast<char*>(_dn.c_str()));
}
int devc = _devicenames.size(); int devc = _devicenames.size();
char **devicenames = (_devicenames.empty()) ? NULL : _devicenames.data(); char **devicenames = (_devicenames.empty()) ? NULL : _devicenames.data();