FOSS/xfce4-taskmanager
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

please cppcheck, check for i < N_COLUMNS before using i to access the array (#10664)

Browse Source
This commit is contained in:
Landry Breuil
2014-11-30 21:48:02 +01:00
parent 994e0c2b9f
commit 095098f87b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/process-tree-view.c
View File

@@ -311,7 +311,7 @@ read_columns_positions (XtmProcessTreeView *treeview)
else else
{ {
columns_positions_split = g_strsplit (columns_positions, ";", N_COLUMNS + 1); columns_positions_split = g_strsplit (columns_positions, ";", N_COLUMNS + 1);
for (i = 0; columns_positions_split[i] != NULL && i < N_COLUMNS; i++) for (i = 0; i < N_COLUMNS && columns_positions_split[i] != NULL; i++)
treeview->columns_positions[i] = (gint)g_ascii_strtoll (columns_positions_split[i], NULL, 10); treeview->columns_positions[i] = (gint)g_ascii_strtoll (columns_positions_split[i], NULL, 10);
g_strfreev (columns_positions_split); g_strfreev (columns_positions_split);
g_free (columns_positions); g_free (columns_positions);