FOSS/xfce4-taskmanager
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Silently and gracefully handle the case when a process disappears before we try to get its argv

Browse Source
This commit is contained in:
Landry Breuil
2014-12-03 18:30:34 +01:00
parent 230e85f5ff
commit 69f56371ba
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/task-manager-bsd.c
View File

@@ -37,6 +37,9 @@
#include <sys/vmmeter.h>
#include "task-manager.h"
#include <errno.h>
extern int errno;
char *state_abbrev[] = {
"", "start", "run", "sleep", "stop", "zomb", "dead", "onproc"
};
@@ -112,16 +115,22 @@ gboolean get_task_list (GArray *task_list)
if (!P_ZOMBIE(&p)) {
size = 128;
if ((args = malloc(size)) == NULL)
errx(1,"failed to allocate memory for argv structures");
errx(1,"failed to allocate memory for argv structures at %zu", size);
for (;; size *= 2) {
if ((args = realloc(args, size)) == NULL)
errx(1,"failed to allocate memory for argv structures of pid %d",t.pid);
errx(1,"failed to allocate memory (size=%zu) for argv structures of pid %d", size, t.pid);
mib[0] = CTL_KERN;
mib[1] = KERN_PROC_ARGS;
mib[2] = t.pid;
mib[3] = KERN_PROC_ARGV;
if (sysctl(mib, 4, args, &size, NULL, 0) == 0)
break;
if (errno != ENOMEM) { /* ESRCH: process disappeared */
/* printf ("process with pid %d disappeared, errno=%d\n", t.pid, errno); */
args[0] ='\0';
args[1] = NULL;
break;
}
}
buf[0] = '\0';
for (ptr = args; *ptr != NULL; ptr++) {