Commit Graph

344 Commits

Author SHA1 Message Date
rim
9ed5f79f8d More float initializers (bug 14401) 2018-05-30 21:47:24 +02:00
rim
1c09b7329b Use the proper types, add casts where necessary (bug 14401) 2018-05-30 21:46:29 +02:00
rim
512e88ad6c timeout is an unsigned integer (bug 14401) 2018-05-30 21:43:08 +02:00
rim
a5f4aaa667 Improve GOptionEntry initialization (bug 14401) 2018-05-30 21:42:04 +02:00
rim
0111851b4d Stop displaying 'Running as <uid> on <hostname>' and remove corresponding code (bug 14401) 2018-05-30 21:31:52 +02:00
rim
8e1b48f8de Move getpwuid() from backends to gui, use getpwuid_r(), call only once on task add. (bug 14401) 2018-05-30 21:31:01 +02:00
rim
40a3e65803 Fix possible file descriptor leak on linux (bug 14401) 2018-05-30 21:30:19 +02:00
rim
66a0d4bfc9 Mark unused params, remove unused macro and args (bug 14401) 2018-05-30 21:29:28 +02:00
rim
ceb5a7d347 Make pid type: GPid (bug 14401) 2018-05-30 21:28:35 +02:00
Ben Burrill
397bb63e23 Improvements to --start-hidden (bug 14343)
* Prints an explanatory warning message when both the window and the
  status icon can't be shown (because --start-hidden is used and "Hide
  into the notification area" is disabled) rather than just exiting.
* Fixes a bug where when the task manager is already running,
  --start-hidden would erroneously activate it.
* Use return instead of exit.  I adopted exit from the gnome docs, but I
  think return makes more sense here.
2018-05-28 22:35:05 +02:00
Ben Burrill
5fdfe369a6 Add --start-hidden command-line option (bug 14343)
When --start-hidden is used, the primary interface is not shown.  If the
"Hide into the notification area" option is enabled, the notification
icon will shown.  Otherwise, the task manager will immediately quit
(running completely in the background would be pointless).
2018-05-28 21:16:21 +02:00
Landry Breuil
c507f13d86 declarations at the beginning of functions (ISO C90 forbids mixed declarations and code) 2018-05-28 21:06:39 +02:00
rim
8d4f013877 Simplify WNCK #ifdefs 2018-05-28 21:05:17 +02:00
Landry Breuil
6f9d95d1f5 declarations at the beginning of functions (ISO C90 forbids mixed declarations and code) 2018-05-28 21:04:45 +02:00
rim
621de4fd13 app-manager optimizations
- simplify lookup by pid
- less calls to wnck_window_get_pid
- use a gint for the pid
2018-05-28 21:00:30 +02:00
Rozhuk Ivan
fd9e313e2e Make sure only printable characters are used in the pretty cmdline display (bug 14172) 2018-05-27 12:00:01 +02:00
Rozhuk Ivan
fd149b63df Rework the way the model is updated (bug 14403)
- Do more lazy updates
- More robust to quick process creation/deletion
- Use bsearch to look in the sorted list of processes.

Should consume less resources..
2018-05-27 11:35:00 +02:00
rim
f27d270f0c Check that treeview isnt NULL in cb_send_signal (bug 14403) 2018-05-27 11:06:32 +02:00
rim
a76b13057c Use sizeof in get_hostname (bug 14401) 2018-05-27 11:04:42 +02:00
rim
3af7e3d491 Use sysctl w/ KERN_PROC_ARGS instead of kvm_getargv in get_task_details() (bug 14401) 2018-05-26 23:55:49 +02:00
Landry Breuil
159c3c1d0c Sort the task list by pid, as we're going to use bsearch() (bug 14403) 2018-05-26 23:52:46 +02:00
rim
704411a38b Properly use float for constants where appropriate (bug 14401, bug 14403) 2018-05-26 23:51:32 +02:00
rim
4d4d0b5073 Add a function comparing tasks (bug 14403) 2018-05-26 23:48:46 +02:00
rim
2329f243fb Properly zero memory where appropriate (bug 14401, bug 14403) 2018-05-26 23:40:11 +02:00
rim
fa797de140 More sizeof uses (bug 14401, bug 14403) 2018-05-26 23:30:22 +02:00
rim
5be9587903 Add G_DEBUG_FMT macro (bug 14401, bug 14403) 2018-05-26 23:27:18 +02:00
rim
c725dee6a9 more sizeof (bug 14401, bug 14403) 2018-05-26 23:21:21 +02:00
rim
5e0fb6f4bc Use sizeof() when appropriate instead of hardcoding values (bug 14401, bug 14403) 2018-05-26 23:19:55 +02:00
rim
c408ee48db Fix clang warning by grouping conditions (bug 14402) 2018-05-26 22:52:37 +02:00
Landry Breuil
5992ec9744 remove unused vars 2018-05-26 22:50:59 +02:00
rim
c1fd3a9d08 Fix clang warning by grouping conditions to actually catch ctrl-q (#14402) 2018-05-26 22:49:27 +02:00
rim
dff8c3e071 use correct type for XGetWindowProperty argument (#14402) 2018-05-26 22:48:06 +02:00
Bobby Hopere
946be33611 Fix UID reporting properly
The patch that was already committed apparently fixes the issue but
using a non-documented method. This patch fixes the issue as described in
"man proc". (The UID is extracted by parsing /proc/*/status not by using
stat() on /proc/*/task). Also, this patch can easily be extended to also
report other UIDs besides the "effective" UID: real, effective, saved
set, and filesystem UIDs.
2017-11-11 22:10:57 +01:00
Alberto Sepo
bd1e267062 Fix incorrect UID reporting (Bug #12970) 2017-06-14 00:13:25 +02:00
Olivier Duchateau
6c6b9f6cad Fix memory usage display (Bug #13371) 2017-02-22 22:58:59 +01:00
Simon Steinbeiss
e23ddb3158 Give the filter/search entry focus by default (Bug #11868) 2017-01-26 23:15:14 +01:00
Simon Steinbeiss
a211e03f3d Fix CPU and memory color labels in Gtk3 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
ec7f5d002e Fix window icon on info and error dialogs 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
d710d130ca Improve crosshair cursor icon 2017-01-26 22:55:30 +01:00
Florian Schüller
793675527a fixed tree traversal 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
5f8f6beffa Add a custom icon for the identify button 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
774a8bd8b4 Try to fix selection for identified windows in tree 2017-01-26 22:55:30 +01:00
Florian Schüller
8c15f28beb show info dialog on error. Icon for dialog missing 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
0cdda50a28 Fix scrolling to the correct PID in listview 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
f9801706d8 Get a working pid-based selection in the list view 2017-01-26 22:55:30 +01:00
Florian Schüller
dfb2deaaca minor string usage fixes 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
166c63101d Select the corresponding row (work in progress) 2017-01-26 22:55:30 +01:00
Florian Schüller
0f73bce47e prepare searching and highlighting a pid 2017-01-26 22:55:30 +01:00
Florian Schüller
807a429eb4 fixed typo, compiles now 2017-01-26 22:55:30 +01:00
Simon Steinbeiss
698ab26a45 Add more information to the identify button 2017-01-26 22:55:30 +01:00