Commit Graph

451 Commits

Author SHA1 Message Date
Klemens Nanni
c456487917 Do not treat missing swap as error on OpenBSD and NetBSD
https://man.openbsd.org/swapctl.2 `SWAP_NSWAP` is always successful.

Do not treat a count of zero as error such that the task manager becomes
usable on systems without any swap configured.

Fix #67.
2022-12-25 18:39:06 +04:00
Jan Ziak
baa1dbd808 Fix process filter crash caused by the use of an uninitialized variable
gtk_tree_view_get_visible_range() documentation states the following:
"Returns TRUE if valid paths were placed in start_path and end_path"

Closes: https://gitlab.xfce.org/apps/xfce4-taskmanager/-/issues/71
Fixes: 8500675125
2022-12-17 21:40:22 +00:00
Gaël Bonithon
8500675125 Stick process view at the top in the absence of user action
Until the user manually scrolls down by some means, the view remains
stuck at the top. When the view subsequently returns to this position,
it automatically sticks again, pending further user action.

Closes: #18
MR: !30
2022-12-15 21:11:11 +00:00
Alexander Schwinn
f5adf3a1cd Revert "Revert "Get rid of GtkHeaderBar""
This reverts commit b9fec9164f.

Bugfix releases are done. So as agreed, this change is
applied again.
2022-07-13 21:50:28 +02:00
Romain Bouvier
1a36cc2959 Fix #53: taskmanager translations
- Remove ENABLE_NLS usage and call xfce_textdomain directly
- This might be broken since a recent glib upgrade (?)
- We don't need to include gi18n.h, libxfce4ui.h already include it (via
  libxfce4util), this remove build time warnings
2022-05-30 13:04:34 +02:00
Simon Steinbeiss
86e1493a22 Fix rendering bug for swap graph (relates to #44) 2022-05-24 11:17:55 +02:00
Simon Steinbeiss
b9fec9164f Revert "Get rid of GtkHeaderBar"
This reverts commit fbb25a1ce6.

The rationale is that we want to do a bugfix/maintenance release and
this change targets Xfce 4.18.
2022-05-24 11:08:04 +02:00
Evangelos Foutras
fa7c8dd091 Fix bindings related to the "show-legend" setting
- Bind to xfconf so the "show-legend" setting is saved when toggled in
  the settings dialog.
- Flip the binding in xtm_process_window_init so the visibility of the
  legend is initialized from XtmSettings.
2022-05-23 11:51:18 +00:00
Simon Steinbeiss
dc832a12b3 Fix rendering bug (Fixes #44) 2022-05-23 09:01:11 +02:00
Hunter Turcin
8a4ad6c8a3 Allow to copy full process command line (#33) 2022-03-04 01:39:12 +00:00
Kevin Bowen
9b68e2dcd8 Rename Private to Resident Bytes (#7)
Closes #7
2022-03-04 01:30:56 +00:00
Alexander Schwinn
fbb25a1ce6 Get rid of GtkHeaderBar 2022-02-10 10:21:44 +00:00
Avinash Sonawane
7ce4c4a891 uid_name has been removed from task struct 2021-11-11 12:03:50 +05:30
Hunter Turcin
644f874d91 Fix invalid casts for "About" and "Help" (Fixes #43) 2021-05-01 23:09:39 +00:00
Jan Ziak
c63dc99a51 Avoid grabbing the filter entry if it is not realized
gtk_widget_grab_focus() shouldn't be called on a widget that isn't
realized. gtk_widget_get_realized(window->filter_entry) will always
evaluate to FALSE at that codepoint.

Closes: https://gitlab.xfce.org/apps/xfce4-taskmanager/-/issues/40
2021-03-12 01:45:38 +01:00
Yousuf Philips
0d06dd82cf Show localized website label 2021-03-12 00:20:52 +00:00
Yousuf Philips
cc10804ec5 Updated copyright year, authors, and project links 2021-02-27 22:34:18 +01:00
Simon Steinbeiss
0ea0e8f4be Fix restoring the window size (Fixes #39) 2021-02-27 08:21:43 +01:00
Simon Steinbeiss
e0fc0ad2b4 Improve wording of systray option (Fixes #19) 2021-02-26 00:59:31 +01:00
Simon Steinbeiss
2ea1b21661 Replace GtkImageMenuItem with GtkMenuItem 2021-02-18 17:32:57 +01:00
Simon Steinbeiss
b376e3d1b0 Store column positions again 2021-02-18 17:30:56 +01:00
Simon Steinbeiss
31feaf1d26 Store sort-column-id and sort-type (Fixes #36) 2021-02-18 16:28:24 +01:00
Simon Steinbeiss
36e428bee4 Also include swap in the memory graph 2021-02-12 02:11:27 +01:00
Simon Steinbeiss
0c7c789d48 Reduce drawing code 2021-02-12 01:50:12 +01:00
Simon Steinbeiss
7617d52304 Reduce borders of graphs 2021-02-12 01:45:24 +01:00
Simon Steinbeiss
28e947b36d Fix erroneous binding of settings (Fixes #37) 2021-02-08 11:15:07 +01:00
Olaf Hering
a6823b8bd0 include stdlib.h because exit() is used
Fixes commit a5aeafc15f

Signed-off-by: Olaf Hering <olaf@aepfle.de>
2021-02-01 15:29:14 +01:00
Olaf Hering
c5621ec523 remove GLIB_CHECK_VERSION checks
The minimal gtk version is 3.22, which implies glib is at least 2.50.0.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
2021-02-01 15:29:14 +01:00
Yousuf Philips
a93616adfb statusbar: Use better color that works well with both light and dark themes (!17)
Improved fix for #26
2021-01-31 23:45:13 +01:00
Simon Steinbeiss
1dcc9e5afd Fix handling "show-legend" setting
When switching back to using the XtmSettings object this binding was
left over and only hooked up to xfconf.
2021-01-26 09:01:02 +01:00
Simon Steinbeiss
7d24873290 Handle Esc key correctly with hidden filter 2021-01-26 08:56:47 +01:00
Simon Steinbeiss
1b0aaad892 Drop unused var and sort copyright 2021-01-25 14:15:40 +01:00
Simon Steinbeiss
07dd87723b Show/hide filterbar with Ctrl+f and clear with Esc
This commit fixes #30
This commit fixes #35
2021-01-25 14:15:40 +01:00
Simon Steinbeiss
575fcaad15 Properly close settings dialog 2021-01-25 14:15:40 +01:00
Simon Steinbeiss
a5aeafc15f Port to xfconf
The internal XtmSettings object is retained so we don't have to refactor
everything, but the backend now uses Xfconf over the rc file.
2021-01-25 14:15:40 +01:00
Olaf Hering
a511e34029 Remove GSourceFunc casts
Convert the callback into a real GSourceFunc.

Split data gathering and timeout handling:
collect_data() does what the name suggests.
init_timeout() will establish a timer.
force_timeout_update() did what collect_data() does.
timeout was in fact a timer_id.

No change in behavior intended.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
2021-01-21 17:20:24 +01:00
Gaël Bonithon
e25b5246b2 Fix compilation warnings 2021-01-21 17:14:34 +01:00
Gaël Bonithon
8ee05eaa7f Simplify "query-tooltip" signal handler
See discussion in https://gitlab.xfce.org/apps/xfce4-taskmanager/-/merge_requests/6#note_22855
2021-01-21 17:14:34 +01:00
Simon Steinbeiss
ab7a0c4e62 Hide filter entry by default 2021-01-20 08:53:11 +01:00
Simon Steinbeiss
4cc1da04d3 Add unit to refresh rate setting 2021-01-20 08:26:59 +01:00
Simon Steinbeiss
bebb2c236c Add tooltips to headerbar buttons 2021-01-20 08:26:32 +01:00
Simon Steinbeiss
ed1574d480 Drop padding 2021-01-19 17:01:51 +01:00
Simon Steinbeiss
59c0131f21 Use infobar for root warning box 2021-01-19 13:25:57 +01:00
Simon Steinbeiss
7005713f90 Ellipsize memory and swap labels (Fixes #32)
Also show the full values in a tooltip.
2021-01-19 13:25:57 +01:00
Simon Steinbeiss
81df60a8ac Set window icon in glade file 2021-01-19 13:25:57 +01:00
Simon Steinbeiss
19b888fcfe Replace fitler entry with GtkSearchBar 2021-01-19 13:25:57 +01:00
Simon Steinbeiss
847ed1ad92 Switch to regular headerbar 2021-01-19 13:25:57 +01:00
Simon Steinbeiss
5d03025219 settings: Replace toolbar with regular GtkBox 2021-01-19 13:25:57 +01:00
Simon Steinbeiss
265b1c2f5b settings: Hook up refresh rate 2021-01-19 13:25:57 +01:00
Simon Steinbeiss
c03eb44de4 settings: Migrate all settings (apart from refresh rate) 2021-01-19 13:25:57 +01:00