Cleanup on JS code

This commit is contained in:
2017-03-06 11:53:33 +01:00
parent 2b48b5f3dd
commit 89b3d06e8c
4 changed files with 56 additions and 56 deletions

View File

@@ -2,7 +2,7 @@
// GetElement
//
function GetElement(element) {
if (typeof element == "string") {
if (typeof element === "string") {
element = document.getElementById(element);
}
return element;
@@ -15,10 +15,10 @@ function ElementAddClass(element, classname) {
element = GetElement(element);
if (!element) { return; }
var cn = element.className;
if (cn.indexOf(classname) != -1) {
if (cn.indexOf(classname) !== -1) {
return;
}
if (cn != '') {
if (cn !== '') {
classname = ' ' + classname;
}
element.className = cn + classname;

View File

@@ -5,8 +5,8 @@
}
xhr.open("GET", url, true);
xhr.onreadystatechange = function () {
if (xhr.readyState == 4) {
if (xhr.status == 200) {
if (xhr.readyState === 4) {
if (xhr.status === 200) {
if (onData) {
onData(xhr.responseText);
}
@@ -16,7 +16,7 @@
}
}
}
}
};
xhr.send(null);
}
@@ -37,8 +37,8 @@ function SendData(url, data, onData, onError) {
var xhr = new XMLHttpRequest();
xhr.open("POST", url, true);
xhr.onreadystatechange = function () {
if (xhr.readyState == 4) {
if (xhr.status == 200) {
if (xhr.readyState === 4) {
if (xhr.status === 200) {
if (onData) {
onData(xhr.responseText);
}
@@ -48,7 +48,7 @@ function SendData(url, data, onData, onError) {
}
}
}
}
};
xhr.setRequestHeader('Content-Type',
'application/x-www-form-urlencoded');
xhr.send(GetDataQueryString(data));
@@ -74,20 +74,20 @@ function GetFormQueryString(idForm) {
if (elemName) {
if (
elemType.indexOf("TEXT") != -1 ||
elemType.indexOf("TEXTAREA") != -1 ||
elemType.indexOf("PASSWORD") != -1 ||
elemType.indexOf("BUTTON") != -1 ||
elemType.indexOf("HIDDEN") != -1 ||
elemType.indexOf("SUBMIT") != -1 ||
elemType.indexOf("IMAGE") != -1
elemType.indexOf("TEXT") !== -1 ||
elemType.indexOf("TEXTAREA") !== -1 ||
elemType.indexOf("PASSWORD") !== -1 ||
elemType.indexOf("BUTTON") !== -1 ||
elemType.indexOf("HIDDEN") !== -1 ||
elemType.indexOf("SUBMIT") !== -1 ||
elemType.indexOf("IMAGE") !== -1
) {
appendVal(elemName, element.value);
} else if (elemType.indexOf("CHECKBOX") != -1 && element.checked) {
} else if (elemType.indexOf("CHECKBOX") !== -1 && element.checked) {
appendVal(elemName, element.value ? element.value : "On");
} else if (elemType.indexOf("RADIO") != -1 && element.checked) {
} else if (elemType.indexOf("RADIO") !== -1 && element.checked) {
appendVal(elemName, element.value);
} else if (elemType.indexOf("SELECT") != -1) {
} else if (elemType.indexOf("SELECT") !== -1) {
for (var j = 0; j < element.options.length; j++) {
var option = element.options[j];
if (option.selected) {
@@ -106,8 +106,8 @@ function SendForm(url, idForm, onData, onError) {
var xhr = new XMLHttpRequest();
xhr.open("POST", url, true);
xhr.onreadystatechange = function () {
if (xhr.readyState == 4) {
if (xhr.status == 200) {
if (xhr.readyState === 4) {
if (xhr.status === 200) {
if (onData) {
onData(xhr.responseText);
}
@@ -117,7 +117,7 @@ function SendForm(url, idForm, onData, onError) {
}
}
}
}
};
xhr.setRequestHeader('Content-Type',
'application/x-www-form-urlencoded');
xhr.send(GetFormQueryString(idForm));

View File

@@ -333,7 +333,7 @@ Card.prototype = {
},
OnMove: function () {
var card = this;
if (this.cfg.Connected == false) {
if (this.cfg.Connected === false) {
card.Reset();
return;
}
@@ -349,20 +349,20 @@ Card.prototype = {
function (responseText) {
try {
var recvData = JSON.parse(responseText);
if (recvData && recvData instanceof Object && recvData.IsOK == true) {
if (recvData && recvData instanceof Object && recvData.IsOK === true) {
card.SetNew();
} else {
card.Reset();
}
} catch (e) { }
} catch (e) { /* Empty */ }
}, function () {
card.Reset();
});
},
OnEdit: function () {
if (this.Title != this.newTitle || this.Body != this.newBody) {
if (this.Title !== this.newTitle || this.Body !== this.newBody) {
var card = this;
if (this.cfg.Connected == false) {
if (this.cfg.Connected === false) {
card.Reset();
return;
}
@@ -378,12 +378,12 @@ Card.prototype = {
function (responseText) {
try {
var recvData = JSON.parse(responseText);
if (recvData && recvData instanceof Object && recvData.IsOK == true) {
if (recvData && recvData instanceof Object && recvData.IsOK === true) {
card.SetNew();
} else {
card.Reset();
}
} catch (e) { }
} catch (e) { /* Empty */ }
}, function () {
card.Reset();
});
@@ -392,11 +392,11 @@ Card.prototype = {
OnDelete: function () {
var card = this;
this.Hide();
if (this.cfg.Connected == false) {
if (this.cfg.Connected === false) {
this.Show();
return;
}
if (this.IDCard == 0) {
if (this.IDCard === 0) {
this.RemoveFromContainer();
this.cfg.RemoveCardByID(card.IDCard);
return;
@@ -411,7 +411,7 @@ Card.prototype = {
function (responseText) {
try {
var recvData = JSON.parse(responseText);
if (recvData && recvData instanceof Object && recvData.IsOK == true) {
if (recvData && recvData instanceof Object && recvData.IsOK === true) {
card.RemoveFromContainer();
if (card.IDCard > 0) {
card.cfg.RemoveCardByID(card.IDCard);
@@ -419,14 +419,14 @@ Card.prototype = {
} else {
card.Show();
}
} catch (e) { }
} catch (e) { /* Empty */ }
}, function () {
card.Show();
});
},
OnCreate: function () {
var card = this;
if (this.cfg.Connected == false) {
if (this.cfg.Connected === false) {
card.OnDelete();
return;
}
@@ -443,13 +443,13 @@ Card.prototype = {
function (responseText) {
try {
var recvData = JSON.parse(responseText);
if (recvData && recvData instanceof Object && recvData.IsOK == true) {
if (recvData && recvData instanceof Object && recvData.IsOK === true) {
//card.IDCard = parseInt(recvData.ReturnValue);
card.OnDelete();
} else {
card.OnDelete();
}
} catch (e) { }
} catch (e) { /* Empty */ }
}, function () {
card.OnDelete();
});
@@ -565,7 +565,7 @@ Card.prototype = {
},
btnEdit_Click: function (evt) {
evt.preventDefault();
if (this.Editing == false) {
if (this.Editing === false) {
this.EnterEditionMode();
} else {
this.ExitEditionMode();
@@ -593,14 +593,14 @@ Card.prototype = {
evt.preventDefault();
this.ExitEditionMode();
this.Reset();
if (this.IDCard == 0) {
if (this.IDCard === 0) {
this.OnDelete();
}
return false;
},
btnDelete_Click: function (evt) {
evt.preventDefault();
if (this.IDCard == 0 || confirm(this.cfg.Texts.ConfirmDelete)) {
if (this.IDCard === 0 || confirm(this.cfg.Texts.ConfirmDelete)) {
this.OnDelete();
}
return false;
@@ -619,7 +619,7 @@ function RunCardBoard(cfg) {
cfg.GetCardByID = function (idCard) {
for (var i = 0, n = this.Cards.length; i < n; i++) {
var card = this.Cards[i];
if (card.IDCard == idCard) {
if (card.IDCard === idCard) {
return card;
}
}
@@ -628,12 +628,12 @@ function RunCardBoard(cfg) {
cfg.RemoveCardByID = function (idCard) {
for (var i = 0, n = this.Cards.length; i < n; i++) {
var card = this.Cards[i];
if (card.IDCard == idCard) {
if (card.IDCard === idCard) {
this.Cards.splice(i, 1);
}
}
return false;
}
};
var ProcessCardCreateEvent = function (cardEvent) {
var card = new Card(cfg, cardEvent.IDCard, cardEvent.Title, cardEvent.Body, cardEvent.X, cardEvent.Y);
@@ -641,19 +641,19 @@ function RunCardBoard(cfg) {
var ProcessCardMoveEvent = function (cardEvent) {
var card = cfg.GetCardByID(cardEvent.IDCard);
if (card == null) { return; }
if (card === null) { return; }
card.Move(cardEvent.X, cardEvent.Y);
};
var ProcessCardEditEvent = function (cardEvent) {
var card = cfg.GetCardByID(cardEvent.IDCard);
if (card == null) { return; }
if (card === null) { return; }
card.Edit(cardEvent.Title, cardEvent.Body);
};
var ProcessCardDeleteEvent = function (cardEvent) {
var card = cfg.GetCardByID(cardEvent.IDCard);
if (card == null) { return; }
if (card === null) { return; }
card.RemoveFromContainer(cfg.divBoard);
};
@@ -668,16 +668,16 @@ function RunCardBoard(cfg) {
if (cardEvent.IDCardEvent > cfg.IDCardEvent) {
cfg.IDCardEvent = cardEvent.IDCardEvent;
}
if (cardEvent.EventType == "CardCreate") {
if (cardEvent.EventType === "CardCreate") {
ProcessCardCreateEvent(cardEvent);
}
if (cardEvent.EventType == "CardMove") {
if (cardEvent.EventType === "CardMove") {
ProcessCardMoveEvent(cardEvent);
}
if (cardEvent.EventType == "CardEdit") {
if (cardEvent.EventType === "CardEdit") {
ProcessCardEditEvent(cardEvent);
}
if (cardEvent.EventType == "CardDelete") {
if (cardEvent.EventType === "CardDelete") {
ProcessCardDeleteEvent(cardEvent);
}
}
@@ -701,7 +701,7 @@ function RunCardBoard(cfg) {
var data = {
"IDBoard": cfg.IDBoard,
"IDCardEvent": cfg.IDCardEvent,
"TimePoolData": ((cfg.Connected == false) ? "0" : String(cfg.TimePoolData)),
"TimePoolData": ((cfg.Connected === false) ? "0" : String(cfg.TimePoolData)),
"TimeStamp": new Date().getTime()
};
SendRequest(cfg.ServiceUrl, data, ReciveCardEventData, ErrorCardEventData);

View File

@@ -82,7 +82,7 @@
var RequestChatData = function () {
var ReciveChatData = function (responseText) {
// Mark as connected
if (cfg.Connected == false) {
if (cfg.Connected === false) {
if (cfg.Minimized) {
cfg.lblTitle.innerHTML = cfg.Texts.Chat;
} else {
@@ -98,7 +98,7 @@
if (recvMsgs) {
var msgCount = 0;
var scrollChat = false;
if (cfg.Minimized == false && cfg.divChat.scrollTop > (cfg.divChat.scrollHeight - cfg.divChat.offsetHeight)) {
if (cfg.Minimized === false && cfg.divChat.scrollTop > (cfg.divChat.scrollHeight - cfg.divChat.offsetHeight)) {
scrollChat = true;
}
@@ -108,7 +108,7 @@
if (cfg.IDMessage < msg.IDMessage) {
cfg.IDMessage = msg.IDMessage;
var elemMessage = CreateMessageDOM(msg,
(msg.UserName == cfg.UserName),
(msg.UserName === cfg.UserName),
(cfg.LastUser !== msg.UserName));
cfg.LastUser = msg.UserName;
frag.appendChild(elemMessage);
@@ -119,7 +119,7 @@
if (scrollChat) {
cfg.divChat.scrollTop = cfg.divChat.scrollHeight;
}
if (cfg.Minimized && cfg.FirstMessages == false && msgCount > 0) {
if (cfg.Minimized && cfg.FirstMessages === false && msgCount > 0) {
cfg.lblTitle.innerHTML = cfg.Texts.NewMessages;
cfg.lblTitle.className = "titleChatAlert";
}
@@ -152,7 +152,7 @@
var data = {
"IDMessageBoard": cfg.IDMessageBoard,
"IDMessage": cfg.IDMessage,
"TimePoolData": ((cfg.FirstMessages || cfg.Connected == false) ? "0" : String(cfg.TimePoolData)),
"TimePoolData": ((cfg.FirstMessages || cfg.Connected === false) ? "0" : String(cfg.TimePoolData)),
"TimeStamp": new Date().getTime()
};
SendRequest(cfg.ServiceUrl, data, ReciveChatData, ErrorChatData);
@@ -163,7 +163,7 @@
function SendChat(cfg) {
cfg.txtText = GetElement(cfg.txtText);
if (cfg.txtText.value.trim() == "") {
if (cfg.txtText.value.trim() === "") {
return;
}